Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rendering and arm movement fixes #474

Merged
merged 3 commits into from
Apr 23, 2024
Merged

rendering and arm movement fixes #474

merged 3 commits into from
Apr 23, 2024

Conversation

reginald-mclean
Copy link
Collaborator

this PR is similar to #473 but removes the docs changes. This PR explicitly fixes #443 and #467

@reginald-mclean reginald-mclean mentioned this pull request Apr 23, 2024
Closed
pseudo-rnd-thoughts
pseudo-rnd-thoughts reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@pseudo-rnd-thoughts pseudo-rnd-thoughts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't understand mujoco enough but looks good other than the rogue print statement

metaworld/envs/mujoco/sawyer_xyz/v2/sawyer_handle_press_side_v2.py Outdated
@@ -74,7 +74,7 @@ def evaluate_state(self, obs, action):
object_grasped,
in_place,
) = self.compute_reward(action, obs)

print(target_to_obj)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove

@reginald-mclean reginald-mclean merged commit 87ac948 into master Apr 23, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pseudo-rnd-thoughts pseudo-rnd-thoughts pseudo-rnd-thoughts left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Objects move slightly after reset
2 participants
@reginald-mclean @pseudo-rnd-thoughts